feat(android) bump minimum required version to 26 aka Oreo #15493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a 1.2% cummulative usage change according to [0] and it allows us to simplify some code going forward. [0]: https://apilevels.com/
Calinteodor
reviewed
Jan 17, 2025
| @@ -53,7 +52,7 @@ public PictureInPictureModule(ReactApplicationContext reactContext) { | |||
| // Android Go devices don't support PiP. There doesn't seem to be a better way to detect it than | |||
| // to use ActivityManager.isLowRamDevice(). | |||
| // https://stackoverflow.com/questions/58340558/how-to-detect-android-go | |||
| isSupported = Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && !am.isLowRamDevice(); | |||
| isSupported = !am.isLowRamDevice(); | |||
There was a problem hiding this comment.
We may have an issue here. With a fresh start and start screen sharing tapped, there is a conflict between pip and screen sharing.
There was a problem hiding this comment.
Is that new with this PR? On your device that will return true anyway so the change is a no-op.
See the comment here though:
There was a problem hiding this comment.
I think the problem is the permissions dialog. Our activity goes to the background for a sec and we try to enter pip, but fail.
We can make this a log line, which is probably better, but that's not related with the PR.
There was a problem hiding this comment.
Hmm your're right. Not related to the PR.
Calinteodor
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a 1.2% cummulative usage change according to 0 and it allows us to simplify some code going forward.